search

sherwin97 / ML-Project----Predicting-solubility-

A personal project to predict solubility of given molecules using their molecular descriptors.
1 stars 1 forks source link

hardcoded paths #1

Closed linminhtoo closed 2 years ago

linminhtoo commented 2 years ago

https://github.com/sherwin97/ML-Project----Predicting-solubility-/blob/5f50a0998def4d6dfa5ad4b0201555ede0841335/data.py#L7-L9

not advisable to hardcode paths. please use argparse.ArgumentParser to parse user-provided arguments from the commandline. and then please update the README with an example command of running it.

linminhtoo commented 2 years ago

addressed by #4