shesek / spark-wallet

⚡️ A minimalistic wallet GUI for c-lightning, accessible over the web or through mobile and desktop apps.
MIT License
341 stars 75 forks source link

Create a username/password entry field in the web app #172

Open dr-bonez opened 3 years ago

dr-bonez commented 3 years ago

Not all browsers support WWW-Authenticate, and it's a bad experience in general. Password managers don't support it, if you cancel it you often can't get back to it without clearing site data, and you often can't change tabs without cancelling it.

A standard username password input field would be much nicer :)

shesek commented 3 years ago

The recommend authentication method is using the cookie file (the default if you don't specify credentials) and the pairing url, which you can get with --pairing-url. This gives you a link that you can open in the browser and automatically get logged in. You can also use --pairing-qr to get a QR with the same URL, for scanning from mobile (especially useful in conjunction with --onion).

Do you find a web based username/password logic preferable to this?

dr-bonez commented 3 years ago

The pairing url is great! But for users who find themselves navigating directly to the base url, it would be nice to show them an in-app login screen.