Incorrect Version 0.0.0 is shown in google-play

shesek / spark-wallet

⚡️ A minimalistic wallet GUI for c-lightning, accessible over the web or through mobile and desktop apps.

MIT License

341 stars 75 forks source link

Incorrect Version 0.0.0 is shown in google-play #179

Closed emanuelb closed 2 years ago

emanuelb commented 3 years ago

Visit: https://play.google.com/store/apps/details?id=com.spark.wallet

Shows "Current Version: 0.0.0"

probably the VersionCode/VersionName is set incorrectly in android build?

while latest release on github is 0.2.17 https://github.com/shesek/spark-wallet/releases

shesek commented 2 years ago

Thanks for reporting this!

The versionCode (internal non-user-visible incrementing integer version number) was being updated correctly, but the versionName which is what's visible on the Play Store was indeed not. This should now be fixed by d7ea4870c96d885aad57253417e782ffa02b3700, the next release will have its version number displayed correctly.

And just to clarify, the release on the Play Store does match the latest on GitHub releases (versionName=0.2.17 / versionCode=219).