Generating BOLT12 offers no longer working for Core Lightning v22.11 (SOLVED)

shesek / spark-wallet

⚡️ A minimalistic wallet GUI for c-lightning, accessible over the web or through mobile and desktop apps.

MIT License

344 stars 77 forks source link

Generating BOLT12 offers no longer working for Core Lightning v22.11 (SOLVED) #205

Open hMsats opened 1 year ago

hMsats commented 1 year ago

Creating a bolt12 in spark-wallet is no longer working for the latest core lightning release.

IS SPARK-WALLET STILL BEING MAINTAINED???

ulrichard commented 1 year ago

would be cool, if this worked again.

hMsats commented 1 year ago

I couldn't find the error and looked at it with my (genius) son. The breaking change in Core Lightning is here. The variable bolt12_unsigned was removed while spark-wallet still expects it. So we have to change bolt12_unsigned into just bolt12. This needs to be done in client/src/views/util.js and client/src/views/offers.js. Created a pull request. @ulrichard hope this solves it for you as well!