search

shesek / spark-wallet

⚡️ A minimalistic wallet GUI for c-lightning, accessible over the web or through mobile and desktop apps.
MIT License
344 stars 77 forks source link

change bolt12_unsigned to bolt12 #207

Open hMsats opened 1 year ago

hMsats commented 1 year ago

The breaking change in Core Lightning is here. The variable bolt12_unsigned was removed while spark-wallet still expects it. So we have to change bolt12_unsigned into bolt12. Because of this generating a (qr code of a) reusable offer in spark-wallet no longer worked.

cryptoquick commented 1 year ago

This is really valuable work! CL 23.05 support is huge. I'm not sure if shesek still intends to maintain this repo, would you be open to maintaining a fork?

hMsats commented 1 year ago

@cryptoquick

Thanks for the acknowledgment but I'm not qualified enough for such a task. It was already hard to find the stuff that had to be changed to get spark-wallet working again especially with "allow-deprecated-apis=false" in config so it will keep working in the (near) future. Nevertheless a fully working spark-wallet for usd can be found here.