Breaking changes will be documented here, and deprecation warnings added to JS code where possible, at least one major version before the change is made.
Types of Breaking Changes
This document uses the following convention to categorize breaking changes:
API Changed: An API was changed in such a way that code that has not been updated is guaranteed to throw an exception.
Behavior Changed: The behavior of Electron has changed, but not in such a way that an exception will necessarily be thrown.
Default Changed: Code depending on the old default may break, not necessarily throwing an exception. The old behavior can be restored by explicitly specifying the value.
Deprecated: An API was marked as deprecated. The API will continue to function, but will emit a deprecation warning, and will be removed in a future release.
Removed: An API or feature was removed, and is no longer supported by Electron.
BrowserWindow.setTrafficLightPosition(position) has been removed, the
BrowserWindow.setWindowButtonPosition(position) API should be used instead
which accepts null instead of { x: 0, y: 0 } to reset the position to
system default.
// Removed in Electron 28
win.setTrafficLightPosition({ x: 10, y: 10 })
win.setTrafficLightPosition({ x: 0, y: 0 })
// Replace with
win.setWindowButtonPosition({ x: 10, y: 10 })
win.setWindowButtonPosition(null)
Removed: BrowserWindow.getTrafficLightPosition()
BrowserWindow.getTrafficLightPosition() has been removed, the
BrowserWindow.getWindowButtonPosition() API should be used instead
which returns null instead of { x: 0, y: 0 } when there is no custom
position.
// Removed in Electron 28
const pos = win.getTrafficLightPosition()
if (pos.x === 0 && pos.y === 0) {
// No custom position.
}
// Replace with
const ret = win.getWindowButtonPosition()
if (ret === null) {
</tr></table>
... (truncated)
Commits
2dee878 fix: avoid package.json check on built-in modules (#39425)
b026a66 ci: fix hang when validating AppVeyor artifacts (#39398)
7a4948b chore: cherry-pick 4 changes from Release-0-M115 (#39269)
878f184 fix: do not resolve electron entrypoints on disk (#39248)
bbe9d8b ci: fail appveyor build if artifacts are missing (#39218)
047fdbf build: disable unneeded depot_tools update on Windows CI (#39017)
1f91895 chore: cherry-pick 4 changes from Release-3-M114 (#38949)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/shesek/spark-wallet/network/alerts).
Bumps electron from 8.5.5 to 22.3.21.
Release notes
Sourced from electron's releases.
... (truncated)
Changelog
Sourced from electron's changelog.
... (truncated)
Commits
2dee878
fix: avoid package.json check on built-in modules (#39425)b026a66
ci: fix hang when validating AppVeyor artifacts (#39398)7a4948b
chore: cherry-pick 4 changes from Release-0-M115 (#39269)878f184
fix: do not resolve electron entrypoints on disk (#39248)bbe9d8b
ci: fail appveyor build if artifacts are missing (#39218)047fdbf
build: disable unneeded depot_tools update on Windows CI (#39017)1f91895
chore: cherry-pick 4 changes from Release-3-M114 (#38949)4ade2a6
build: use Xcode 13.4.1 (#38822)a68e328
chore: cherry-pick 5 changes from Release-2-M114, Release-1-M110 and Release-...047f474
chore: cherry-pick 7 changes from Release-0-M114 (#38534)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show