search

shesek / spark-wallet

⚡️ A minimalistic wallet GUI for c-lightning, accessible over the web or through mobile and desktop apps.
MIT License
345 stars 76 forks source link

Add connected channel aliases in channel list #51

Open JaviLib opened 5 years ago

JaviLib commented 5 years ago

In the list of channels in the web version at least, we can't effectively see who are the names of the nodes we are connected to. We need at least the alias shown to the right of the amount (without requiring to open down the detailed information).

shesek commented 5 years ago

This is a bit tricky because aliases are not reported in the channels list returned from listpeers, you have to query for each peer's alias separately using listnodes <pubkey>. Meaning, a list of 100 channels would require a total of 101 RPC calls.

@cdecker How do you feel about making this information available in listpeers?

JaviLib commented 5 years ago

I know it is a bit tricky, I asked for support here but it seems they are not going to add it. One solution to this is to use some kind of cache.

k3tan172 commented 5 years ago

Could a possible solution be for the spark wallet user to name the channel themselves? Something I can input myself so I can identify who the channel is with?

shesek commented 5 years ago

@k3tan25 This is a pretty cool idea that sidesteps the issue with aliases, I'll look into implementing this. Added #68 to keep track of that.

k3tan172 commented 5 years ago

I've just installed the 'summary' plugin from https://github.com/lightningd/plugins, the output of which shows the channel aliases. Could this be somehow integrated in to spark-wallet?

JaviLib commented 5 years ago

10 months after, do we have any progress on this?

Darth-Coin commented 4 years ago

Also will like to add to this enhancement: date/time when the channel was created, below the channel name.

shesek commented 4 years ago

@Darth-Coin If you open the channel details, you can see the age of the channel in terms of number of blocks, as well as an estimate of a human-readable duration (based on the number of blocks). The timestamp itself is not made available via c-lightning, so this is the best I could do.