Open hlayisanimazuze opened 3 weeks ago
Related Item #1183
@James-Baloyi, please check this requirement: If Custom JS defined for Icon property - Is Editable and Default value config properties should be disabled. Since with the latest changes, it does not work accordinlgy when a custom JS is defined for Icon property
Here's a URL you can use to test your latest changes: https://function-adminportal-test.shesha.dev/dynamic/TestModule/iconPicker-details?id=31bac1bb-a1cd-4bcd-92f9-184c1d3feed0
@James-Baloyi Please also ensure that there is enough space to accommodate all icons by default. The current implementation cut off the edges of some icons, especially icons outlined with a circle, see the screenshot below.
Hey @James-Baloyi please fix issues below
if (data.gender === 1) { return 'ManOutlined'; } else if (data.gender === 2) { return 'WomanOutlined'; } else { return 'CloseOutlined'; }
. https://function-adminportal-test.shesha.dev/dynamic/TestModule/iconPicker-tableOld change![image](https://github.com/shesha-io/shesha-framework/assets/151041759/296159bb-8de7-41a3-a7ab-91e407c3b8ee)
New implementation![image](https://github.com/shesha-io/shesha-framework/assets/151041759/fb5d656c-41b8-4d33-93d2-125df31d15b6)