shesha-io / shesha-framework

An open-source Low-Code development framework for .NET developers. Create .NET based business applications with 80% less code.
https://shesha.io
Apache License 2.0
327 stars 57 forks source link

Icon Picker clean up #1657

Open hlayisanimazuze opened 3 weeks ago

hlayisanimazuze commented 3 weeks ago

Old change image

New implementation image

hlayisanimazuze commented 3 weeks ago

Related Item #1183

hlayisanimazuze commented 3 weeks ago

@James-Baloyi, please check this requirement: If Custom JS defined for Icon property - Is Editable and Default value config properties should be disabled. Since with the latest changes, it does not work accordinlgy when a custom JS is defined for Icon property

Here's a URL you can use to test your latest changes: https://function-adminportal-test.shesha.dev/dynamic/TestModule/iconPicker-details?id=31bac1bb-a1cd-4bcd-92f9-184c1d3feed0

Tshepiso-R commented 3 weeks ago

@James-Baloyi Please also ensure that there is enough space to accommodate all icons by default. The current implementation cut off the edges of some icons, especially icons outlined with a circle, see the screenshot below.

image

Tshepiso-R commented 2 weeks ago

Hey @James-Baloyi please fix issues below

  1. The icon becomes left-aligned only when you adjust its size.
  2. There isn't enough space to fit all icons by default, causing some icons to have their edges cut off in the current implementation.
  3. The icon displayed in the details view does not show data after it is created.
  4. When an icon is selected from the properties panel, it gets removed upon saving and refreshing. The selected icon still appears when rendered, but it disappears from the properties panel.
  5. The padding margin does not function correctly when the default icon is not configured.