search

shesha-io / shesha-framework

An open-source Low-Code development framework for .NET developers. Create .NET based business applications with 80% less code.
https://shesha.io
Apache License 2.0
315 stars 50 forks source link

The wizard component breaks when using JS to configure wizard steps #641

Closed Tshepiso-R closed 6 months ago

Tshepiso-R commented 6 months ago

Issues

Repro Steps

https://function-adminportal-test.shesha.dev/dynamic/Shesha/wizard-component-test-table

  1. Click on the link and navigate to the form designer
  2. From the wizard properties, click Configure Wizard Steps.
  3. Click on step 2 and on the property "Title", use JS to return the title
  4. Actual Results: The component break and display the error below
  5. Check the "Diaabled property or use JS"
  6. Actual results: The step does not get disabled when you render
  7. On the Icon property, switch to JS and return any icon name
  8. Actual results: the icon does not display
  9. Navigate to either Next button, Back button,or Done button and configure the name Text property using JS
  10. Actual results: The configured Text does not display

image

Tshepiso-R commented 6 months ago

Hi, @AlexStepantsov

  1. I have noted that you can't use a condition to configure a property when configuring the wizard steps, E.g. If you want to disable a step based on a condition, you then write return data.checkbox1 or `return contexts.appContext. checkbox1 the Disabled property. When you use this method, it does not respond accordingly.
  2. The Disabled property is still not working, since we still have the property Custom enabled, are we supposed to focus on it not?
AlexStepantsov commented 6 months ago

hi @Tshepiso-R Fixed

The "Disable" property was added by mistake. I deleted it. Please use "Custom Enable".

PS: But the meaning of Disabling is not very clear to me, since the step is still allowed for selection and it is more logical to use visibility. I was not initially involved in the development of the component, so I cannot explain the implementation details.

Tshepiso-R commented 6 months ago

Hi @AlexStepantsov Noted, Thanks.