shettima / bigbluebutton

Automatically exported from code.google.com/p/bigbluebutton
0 stars 0 forks source link

Wrong SDP informations sent when dialing FreeSWITCH #1355

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
As reported by Matteo on the developers forum 
https://groups.google.com/d/topic/bigbluebutton-dev/8wrOABwYQfI/discussion 
there is an error in the SDP informations sent when dialing a remote 
FreeSWITCH. I was able to reproduce the error. First I've installed BBB from 
packages on an Ubuntu 10.04.4 64-bit machine. My BBB local IP is 192.168.1.239. 
Then I configured BBB to use an external FreeSWITCH, located at 192.168.1.32 on 
the same LAN network, by setting the parameter esl.host=192.168.1.32 in 
/usr/share/red5/webapps/bigbluebutton/WEB-INF/bigbluebutton.properties and 
sip.server.host=192.168.1.32 in 
/usr/share/red5/webapps/sip/WEB-INF/bigbluebutton-sip.properties. Al the ports 
were open by the firewall on both sides. With that settings I was unable to 
join a conference with audio. By doing a tcpdump and analyzing the traffic I've 
seen that BBB sent 192.168.1.32 as "From:" IP address to the external 
FreeSWITCH (instead of 192.168.1.239).

Then I've downloaded the v.0.8 Tag sources and found that the problem resides 
in the method initSessionDescriptor of the class CallAgent of the bbb-voice 
application.

This is the code snippet where the error occurs:
SessionDescriptor newSdp = SdpUtils.createInitialSdp(userProfile.username,
                sipProvider.getViaAddress(), userProfile.audioPort,
                userProfile.videoPort, userProfile.audioCodecsPrecedence );

in particular, it is necessary to replace sipProvider.getViaAddress() with a 
method that returns the IP of the BBB box.
I've tried that by hardcoding "192.168.1.239" in place of 
sipProvider.getViaAddress() and after compilation and deployment I was able to 
join the conference with audio.

Original issue reported on code.google.com by alexgo...@gmail.com on 7 Nov 2012 at 4:40

GoogleCodeExporter commented 9 years ago
I've forked the bigbluebutton project on github and resolved the issue on the 
external_freeswitch branch here: 
https://github.com/alexbbb/bigbluebutton/tree/external_freeswitch

Original comment by alexgo...@gmail.com on 8 Nov 2012 at 4:55

GoogleCodeExporter commented 9 years ago
Thanks for the detailed bug report!  We'll look at merging this in with 0.81.  
We may have some more follow-up questions, but we'll post them to this thread.

Original comment by ffdixon@gmail.com on 11 Nov 2012 at 4:28

GoogleCodeExporter commented 9 years ago
Issue 1354 has been merged into this issue.

Original comment by ffdixon@gmail.com on 11 Nov 2012 at 4:29

GoogleCodeExporter commented 9 years ago
Issue 954 has been merged into this issue.

Original comment by ffdixon@gmail.com on 11 Nov 2012 at 4:42

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Today I've made another two commits to the external_freeswitch branch on my 
repo, where I've made some changes to a bunch of sources to be able to map 
conferences by their name instead of their voiceBridge number. Forum discussion 
here: 
https://groups.google.com/forum/?fromgroups#!topic/bigbluebutton-dev/V9ntLIvOX8M

The two commits are totally independent of the one I've made to solve this 
issue, but I thought that it's better to let you know to not waste your time 
when my commit could be merged into the master branch.

I won't commit anything else on the external_freeswitch branch to avoid 
confusion between the different issues I'm working on.

Original comment by alexgo...@gmail.com on 12 Nov 2012 at 4:43

GoogleCodeExporter commented 9 years ago
The pull request has been merged into master.

Original comment by ritza...@gmail.com on 25 Feb 2013 at 3:29