search

shettima / bigbluebutton

Automatically exported from code.google.com/p/bigbluebutton
0 stars 0 forks source link

Make threshold for slideMayHaveTooManyObjects a property in bigbluebutton.properties #1376

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The post at

   https://groups.google.com/group/bigbluebutton-dev/browse_thread/thread/90aac9c156e6d20e#

Gives details on how to reproduce a problem with conversion of slides.

The loss of quality is a result of the threshold in 

   https://github.com/bigbluebutton/bigbluebutton/blob/master/bigbluebutton-web/src/java/org/bigbluebutton/presentation/PdfToSwfSlide.java#L76

Specifically, 

    private boolean slideMayHaveTooManyObjects(File slide) {
        // If the resulting swf file is greater than 500K, it probably contains a lot of objects
        // that it becomes very slow to render on the client. Take an image snapshot instead and
        // use it to generate the SWF file. (ralam Sept 2, 2009)
        return slide.length() > 500000;
    }

this logic has worked well to prevent the user's browser (running Flash) from 
being overloaded by a large .swf file.

However, the capacity for browsers has advanced considerably in the last three 
years.

Extract the value of 500000 into a property into bigbluebutton.properties so 
sites with large slides could adjust the threshold.

Original issue reported on code.google.com by ffdixon@gmail.com on 26 Dec 2012 at 2:19

GoogleCodeExporter commented 9 years ago 
fixed:
https://github.com/bigbluebutton/bigbluebutton/commit/f93d40adfea558bbedbc3533cc
3eb8f3a9e22e52

Original comment by mcmarkos86 on 23 Jan 2013 at 8:58