search

shevchenkos / DynamoDbBackUp

46 stars 23 forks source link

Switch lambda runtime from nodejs4.3 to nodejs10.x #66

Closed forevermatt closed 5 years ago

forevermatt commented 5 years ago

I have tested this change in our AWS account, and the continuous backups (done via that Lambda and an associated DynamoDB trigger) seem to work fine using NodeJS 10.x.

forevermatt commented 5 years ago

Fixes #65

thoean commented 5 years ago

Thanks. No concerns from my side.

However, @shevchenkos is the admin of this repo and the deployment and I'm not collaborating closely with him anymore. I hope he'll see this message soon.

forevermatt commented 5 years ago

Thanks @thoean. Sounds good. 🙂

As a side note, I'm only accessing this code via this repo directly (and our fork of it), not via npm. While updating the npm package would presumably be helpful, this PR is all I'm personally waiting for @shevchenkos to do.

shevchenkos commented 5 years ago

@forevermatt, merged and published. Just let you know, migration to new version of nodejs may cause a long cold start of lambda. I've already faced this problem on my project. AWS Support comment:

Thanks for contacting AWS Premium Support. I understand that you have upgraded your lambda functions to the node10 two weeks back and you see that all those lambda functions taking more time to execute than the time they used to take while running on node6 runtime. You have pointed out correctly that this behavior is seen after the lambda node runtime upgrade. This is the known issue and the lambda team is aware about this. Lambda team is working on improving the architecture. However, I do not have further information or ETA on this.

forevermatt commented 5 years ago

@shevchenkos Thanks for letting me know about about the slower cold-start times (and for getting to this so quickly)! That's good to be aware of.