Open redcape opened 3 years ago
+1 for merging this, it was invaluable for fixing the linked issue.
@etinquis I think this project is abandoned. I had to do an internal fork with just this commit.
@redcape Yeah it seems like it, but one can only hope 😄
Although the remap process for ASM8 supports higher JDKs, remapping fails on some classes because GetNameClassWriter (which only gets the class name) was throwing an error when processing JDK11 classes with newer features like those from org.jgroups:jgroups.
Example errors:
The fix here is to simply change ASM5 to ASM8, the highest stable version / matching version of the current depended-on ASM.
Additionally, we change StringReader to use the higher ASM version as well to prevent errors for the
strings
command, but do not make any specific changes to process/display additional strings for the newer features available since ASM5 in ClassVisitor.