search

shexSpec / primer

ShEx primer
MIT License
7 stars 5 forks source link

Comments on text #4

Closed kcoyle closed 7 years ago

kcoyle commented 7 years ago

Comments on @tombaker's ShEx Summary

1) I don't think that Boolean has the appropriate meaning in the way it is used here. Many readers will think T/F or 0/1. I'm not exactly sure what meaning is intended, so I don't have a better suggestion.

2) "Cartoon" has various meanings, but the most common one is of an amusing, comical drawing. The use here is more like a sketch or simplified view. That is a valid use of cartoon, but some readers may not be familiar with that usage. I would substitute something like "simplified sketch" for "conceptual cartoon".

3) In the paragraph that contains "If a model in OWL..." (line 17) it would be good to mention the term "open world assumption", even if just adding at the end "In RDF this is called the 'open world assumption.'" Then the next paragraph can describe shex as primarily defining a closed world. The trick here is that there is an open/closed function in shex that is not identical to the RDF/OWL OWA - that is, in Shex a validation can be open or closed, with closed meaning that the RDF can contain only those classes and properties that are included in the Shex graph, and open meaning that triples not defined in Shex are ignored. This distinction should be included (although it may be in the full document).

4) The sentence: "A triple may be seen as an "outgoing arc" from a subject or an "incoming arc" to an object." This sounds like the triple is being defined as just an arc. Maybe this needs to read "A triple may be read as having an arc from a subject to an object, or from an object to a subject." However, I think this sentence should be dropped because its use here isn't clear.

5) (line 69) "...infinite collection of potential RDF graphs..." -> Infinite is a bit much; how about "full range of potential RDF graphs" or something similar?

gkellogg commented 7 years ago

@kcoyle, it's not obvious what text you are referring too; can you reference the document you're reviewing please? (I didn't see this in either the main, or tomedits branches of the primer).

kcoyle commented 7 years ago

I think it's in the comment - https://github.com/shexSpec/primer/blob/gh-pages/Text-to-add.txt

tombaker commented 7 years ago

Thank you, Karen!

I believe these points have all been addressed in the text now. Point 3, in particular, is addressed in a section "Relationship of ShEx to RDF and OWL".