search

shexSpec / schemas

ShEx schemas for common vocabularies and use cases.
MIT License
12 stars 8 forks source link

P50_author/P2093_author_name_string qualifiers #1

Closed VladimirAlexiev closed 5 years ago

VladimirAlexiev commented 7 years ago

https://github.com/shexSpec/schemas/blob/master/Wikidata/wikicite/wikicite_scholarly_article.shex#L19

   (p:P50 @<P50_author>* | p:P2093 @<P2093_author_name_string>*)+ ;

@andrawaag: can you add an example of using a prop as a qualifier, eg P1545 series ordinal

emulatingkat commented 7 years ago

@VladimirAlexiev I added an example:

https://github.com/shexSpec/schemas/blob/master/Wikidata/wikicite/wikicite_scholarly_article.shex#L20 and https://github.com/shexSpec/schemas/blob/master/Wikidata/wikicite/wikicite_scholarly_article.shex#L254

Is this a useful example for your purpose?

VladimirAlexiev commented 7 years ago

No because the qualifier should be used inside author/author_names.

VladimirAlexiev commented 5 years ago

I think these are good examples:

I wasn't sure they can be used this way, but after examining https://github.com/shexSpec/schemas/blob/master/Wikidata/wikicite/wikicite_scholarly_article.shex#L19 I think they do. However, I think "series ordinal" should be made optional and the data type concretized:

pq:P1545 xsd:string?

https://github.com/shexSpec/schemas/blob/master/Wikidata/wikicite/wikicite_scholarly_article.shex#L254 should be deleted.

andrawaag commented 5 years ago

I agree with your comments here. I took the liberty to make the changes accordingly.