shexjs / shex.js

shex.js javascript package
MIT License
58 stars 17 forks source link

Should use `@rdfjs/types` rather than `rdf-js` and move to dependency #350

Open jeswr opened 2 months ago

jeswr commented 2 months ago

What broken?

Typescript types

Version

No response

What happened (e.g., it crashed)?

Usage of @types/rdf-js should be @rdfjs/types instead. See https://github.com/rdfjs/types?tab=readme-ov-file#what-about-typesrdf-js.

Secondly, it should be a dependency in cases where the types are used as part of the API that is exported by the library in order to avoid downstream errors like the following.

$ npm i

> @jeswr/shacl2shex@0.0.0-development prepare
> tsc

node_modules/@shexjs/eval-validator-api/src/validator-api.ts:6:33 - error TS2307: Cannot find module 'rdf-js' or its corresponding type declarations.

6 import {Quad as RdfJsQuad} from "rdf-js";
                                  ~~~~~~~~

node_modules/@shexjs/term/src/shex-term.ts:38:33 - error TS2307: Cannot find module 'rdf-js' or its corresponding type declarations.

38 import {Term as RdfJsTerm} from 'rdf-js';
                                   ~~~~~~~~

node_modules/@shexjs/validator/src/shex-validator.ts:18:44 - error TS2307: Cannot find module 'rdf-js' or its corresponding type declarations.

18 import type {Quad, Term as RdfJsTerm} from 'rdf-js';
                                              ~~~~~~~~

node_modules/@shexjs/validator/src/shex-xsd.ts:4:38 - error TS2307: Cannot find module 'rdf-js' or its corresponding type declarations.

4 import type {Term as RdfJsTerm} from 'rdf-js';
                                       ~~~~~~~~

Found 4 errors in 4 files.

Errors  Files
     1  node_modules/@shexjs/eval-validator-api/src/validator-api.ts:6
     1  node_modules/@shexjs/term/src/shex-term.ts:38
     1  node_modules/@shexjs/validator/src/shex-validator.ts:18
     1  node_modules/@shexjs/validator/src/shex-xsd.ts:4
npm ERR! code 2
npm ERR! path /home/jeswr/Documents/GitHub/jeswr/reasoning-test/shacl2shex
npm ERR! command failed
npm ERR! command sh -c tsc

npm ERR! A complete log of this run can be found in: /home/jeswr/.npm/_logs/2024-04-12T18_34_03_469Z-debug-0.log

What should have happened instead (e.g., it shouldn't crash)?

No response

How can we reproduce this error?

No response