search

shexjs / shex.js

shex.js javascript package
MIT License
58 stars 17 forks source link

Tests failing locally #78

Closed ross-spencer closed 3 years ago

ross-spencer commented 3 years ago

I'm sorry I don't know how to interpret these further, but downloading the library today and running the commands as described: cd node_modules/shex && npm install && npm test I'm seeing the tests fail locally. I've attached the results. Any other help here appreciated.

2020-08-15-test_results.txt

ericprud commented 3 years ago

i'll dig into this. i expect it's because the test repo that it downloads isn't synched with the branch. I typically run the tests by cloning shexSpec/shexTest next to shex.js. The test loader looks there first so I've possibly missed skew with the npm-installed test repo.

ross-spencer commented 3 years ago

Thanks Eric. I appreciate it.

ericprud commented 3 years ago

hi @ross-spencer, i've updated the tests to use cloned git repos instead of the published NPM version. I've also updated the NPM version but, since different branches of shex.js are tested by corresponding branches of shexTest, it made more sense to just use the repo branches. Hopefull the README section is relatively clear about that. Feel free to close this issue if that does the job (or issue PRs to improve it).

ross-spencer commented 3 years ago

I've been having a look at this today, the docs look great and the behavior has definitely changed. I haven't got tests working yet, but I suspect this is more to do with my abilities node. I'll keep playing, and intend to use the library more, but I'll close this now and try and drop some notes back if I find the resolution locally.

ericprud commented 3 years ago

you might need to wipe out your modules and reinstall https://github.com/shexSpec/shex.js/blob/master/bin/reinstallDeps.sh