search

shfty-elysian / elysian-legacy

Field function compiler
0 stars 0 forks source link

Wrapper abstraction for modifying a single shape #117

Closed Shfty closed 1 year ago

Shfty commented 1 year ago

Currently, many existing Shape implementors follow the pattern of composing a DynShape and its module, then calling its entrypoint from a new CONTEXT -> CONTEXT function.

This could be abstracted under a new Wrap type that handles composing the DynShape, leaving the existing implementors to worry about business logic.

Will require a Shape / Combinator / PreModifier / PostModifier equivalent, likely one that re-exposes AsModule functionality via blanket impl.

Shfty commented 1 year ago

Done: Blanket impl unnecessary, implemented as Wrap + Wrapper.