search

shg / org-inline-pdf.el

Inline PDF previewing for Org
GNU General Public License v3.0
48 stars 8 forks source link

feat: support specify the page number of the pdf #4

Closed Elilif closed 1 year ago

Elilif commented 2 years ago

You can use `#+attr_org: :page NUM' to specify the page number.

shg commented 1 year ago

Hi @Elilif

Thank you very much for the PR! And sorry for taking time to respond.

Adding the option for selecting page is great and must be useful. One request is to remove pdftocairo support from this PR. I was also thinking to support for pdftocairo (#1) but I prefer to keep pdf2svg work as well. So could you make this only for page selection and make a seperate PR for pdftocairo support if you like?

Elilif commented 1 year ago

One request is to remove pdftocairo support from this PR

This is my negligence, my original intention was to test pdftocairo and I forgot to make new branch. Sorry for that.

shg commented 1 year ago

Hi @Elilif I have two more requests. Sorry I didn't mentioned these together with the previous one.

There are lines with no change except tabs are replaced with spaces. Please change them back to tabs. Unfortunately this code uses old-fashioned mixed tab/space for indentation.

Please remove the change to define-minor-mode call from this PR. I understand the current code uses old form and would be better updated but I'd like to make it separate from this PR.

Elilif commented 1 year ago

@shg I have updated this PR.

shg commented 1 year ago

Merged and updated README. Thank you!