search

shhossain / computer_science

Computer Science Topics
MIT License
224 stars 233 forks source link

Remove broken code in readme files. (python, cpp, c#, java, etc) #547

Open shhossain opened 2 years ago

shhossain commented 2 years ago

Remove broken code

Lots of broken code in the algorithm folder.

Test the code on readme files and remove those that are not working.

jhuynh06 commented 2 years ago

Can I be assigned to this issue? Thank you!

shhossain commented 2 years ago

@jhuynh06 Sure

shhossain commented 2 years ago

The issue is still open as their is lots of broken code.

Technic143 commented 2 years ago

Dear colleagues, I very new at GitHub. But ready to contribute to solve the issues. Can you explain how can I find non-working code in readme files to fix?

shhossain commented 2 years ago

fork the repository in your local machine and check for codes in readme files. And test the code in a online compiler or local computer if you have that language installed in your machine. And if a code is not running properly you can do two things if you can fix the error fix it and remove it if you can't and submit a pr(pull request). @Technic143

Technic143 commented 2 years ago

OK thanks. Check my understanding please (I already forked the repository). Now I can download readme files from the repository, check them with local Markdown editor and correct. Correct?

Technic143 commented 2 years ago

P.S. I have some knowledge in Python. Some readme files use this correct?

shhossain commented 2 years ago

@Technic143 yes

Technic143 commented 2 years ago

Hello! I corrected: M Colouring Problem\readme.md via PyCharm and pushed this. Can you check did I do it correctly, can you use this?

shhossain commented 2 years ago

You have to create a PUll request. @Technic143

Technic143 commented 2 years ago

I did it in PyCharm, and Pull request was sent to GitHub. Or nevertheless I have to repeat this on GitHub?

Technic143 commented 2 years ago

sorry, Pull is not Push,,,

Technic143 commented 2 years ago

I did, correct?

shhossain commented 2 years ago

@Technic143 merged.

Technic143 commented 2 years ago

OK see thanks!

shhossain commented 2 years ago

@Technic143 welcome.

Technic143 commented 2 years ago

Hello! Is it necessary to correct small typos like comma instead dot or one letter misprint of word in the readme?

shhossain commented 2 years ago

Yes. You can fix any typos. Small or big. @Technic143

Technic143 commented 1 year ago

Hello! Found, that in 0/1 Knapsack Problem chapter Readme file, Python code doesn't work, an error appears. The program is without any comments - this is not easy to check. Is it necessary to find the mistake in the code or maybe find another code in the internet? Or I can try to create own code for the task, what do you think?

shhossain commented 1 year ago

@Technic143 you can fix the code any way you want.

Technic143 commented 1 year ago

Tried to pull the corrections, but c# code is failure. I corrected only Python. Don't know how to proceed.

shhossain commented 1 year ago

@Technic143 no problem. Test don't support c#.

TsiG-404 commented 1 year ago

Hi i saw that in buble sort it doesnt have an example in c# can add an exmple code ?

shhossain commented 1 year ago

@TsiG-404 sure.

TsiG-404 commented 1 year ago

Ok thanks i added the code

adkbbx commented 1 year ago

Hey there, I'm intrested in contributing to this issue do let me know how I can help

shhossain commented 1 year ago

@adkbbx you can add a new section, update or improve the existing readme.

MarcusW03 commented 1 month ago

https://github.com/shhossain/computer_science/pull/770

Updated formatting for Sorting Methods documentation in the readme's. Also fixed some typos and errors I found.