search

shibapm / Komondor

Git Hooks for Swift projects 🐩
MIT License
553 stars 32 forks source link

git-lfs support for hooks? #16

Open klundberg opened 5 years ago

klundberg commented 5 years ago

I'm doing a little bit of investigation into git-lfs, and it appears that it also manages its installation by setting up some hooks (specifically pre-push, post-checkout, post-commit, and post-merge). It stops if komondor already installed hooks into the repo, and recommends either manually editing the hooks scripts, or doing a force overwrite.

In the interest of not having to copy-paste lines into those hook scripts, would komondor be able to detect if git-lfs hooks were already installed, and append komondor's part to the end? Or perhaps komondor could detect if git-lfs is enabled for a repo somehow, and call git-lfs automatically so that developers don't need to manually edit the hooks after installing komondor?

orta commented 5 years ago

Sure, appending seems reasonable to me. I've never used git-lfs, so you're on your own there I'm afraid - but seems reasonable if you can get a simple heuristic that it's that sort of setup.