Closed piterwilson closed 4 years ago
Adding some extra information:
swift --version
Apple Swift version 5.2 (swiftlang-1103.0.32.1 clang-1103.0.32.29)
Target: x86_64-apple-darwin19.3.0
think your timing was just off a little re: #29 which would have fixed the docs
or not, we just have more docs to update actually
@orta thank you for the link to the issue. I can confirm that changing the configuration to the following does work:
// swift-tools-version:5.1
// The swift-tools-version declares the minimum version of Swift required to build this package.
import PackageDescription
let package = Package(
name: "xxx",
platforms: [
.iOS(.v11),
.macOS(.v10_13),
.tvOS(.v11)
],
products: [
// Products define the executables and libraries produced by a package, and make them visible to other packages.
.library(
name: "xxx",
targets: ["xxx"])
],
dependencies: [
.package(url: "https://github.com/shibapm/Komondor.git", from: "1.0.0"),
.package(url: "https://github.com/Realm/SwiftLint", from: "0.35.8")
],
targets: [
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
// Targets can depend on other targets in this package, and on products in packages which this package depends on.
.target(
name: "xxx",
dependencies: []),
.testTarget(
name: "xxxTests",
dependencies: ["xxx"])
]
)
// The settings for the git hooks for our repo
#if canImport(PackageConfig)
import PackageConfig
let config = PackageConfiguration([
"komondor": [
"pre-commit": [
"swift run swiftlint --path Sources --config .swiftlint.yml"
]
]
])
I can see that the import being called PackageConfig
was probably the source of the confusion.
Thanks for the work you put into this package!
Hello,
I'm having trouble getting the basic setup sample to work. I used the instructions here: https://github.com/shibapm/Komondor/blob/master/Documentation/with_swiftpm.md
Which results in this error
May i ask what i could be doing wrong? or is this an issue with Komondor?
Thank you!