Fixing silent failure while creating the hooks - Githubissues

shibapm / Komondor

Git Hooks for Swift projects 🐩

MIT License

552 stars 32 forks source link

Fixing silent failure while creating the hooks #35

Closed dirtyhenry closed 4 years ago

dirtyhenry commented 4 years ago

Hi, and thanks for this awesome project.

I had issues when I tried to install Komondor on a Xcode project of mine and this pull request aims to fix what went wrong:

Some docs were out of date;
At first, the hooks were not created but were logged as they were;
Then using a URL directly without going through absoluteString fixed it for me (and, funny anecdote, it was about the same fix that I suggested on this StackOverflow question, a couple of weeks ago).

All in all, quite small changes, and now my setup works great! 🙏

orta commented 4 years ago

Agree to all of it - sorry it took a while