search

shibapm / Komondor

Git Hooks for Swift projects 🐩
MIT License
552 stars 32 forks source link

Fix Future Package Conflicts #56

Closed leogdion closed 1 year ago

leogdion commented 2 years ago

If someone is using Rocket there's a potential for conflicts in the future:

'komondor': warning: 'komondor' dependency on 'https://github.com/f-meloni/Rocket' conflicts with dependency on 'https://github.com/shibapm/Rocket' which has the same identity 'rocket'. this will be escalated to an error in future versions of SwiftPM.

This fixes that issue in the future.

leogdion commented 2 years ago

@minuscorp could you look at this when you get a chance?

minuscorp commented 2 years ago

The question is, is really rocket needed for this package? Its configuration is empty, so it's no making anything right?

leogdion commented 2 years ago

It's supposed to be used when tagging to remove dev dependencies. It's a dev dependency similar to how SwiftFormat is utilized.

orta commented 2 years ago

This was/is always a constraint in SPM's resolving systems - it's possible that SPM doesn't force downloading of things which aren't referenced by now?

leogdion commented 2 years ago

Right which is why Rocket exists essentially. I'm sure that's the purpose of swift package plugins. Regardless this will break in future versions of Swift if the dependencies aren't consistent.

417-72KI commented 1 year ago

Any updates?

orta commented 1 year ago

We should merge this, as it is correct anyway