search

shibapm / Rocket

Define your release steps 🚀
MIT License
110 stars 15 forks source link

Feature/branch step #19

Closed dalu93 closed 5 years ago

dalu93 commented 5 years ago

Adding branch step as per #18 This should switch branch if it already exists, or create a new one. The push step should push and create the branch remotely, if it doesn't exist.

f-meloni commented 5 years ago

Cool, thank you for the PR. The only thing is that I think it would fail if you launch git checkout -b with an existing branch, then probably i would suggest to make the branchName mandatory, because using master would make it fail almost for every project. Something like this: https://github.com/f-meloni/Rocket/blob/master/Sources/RocketLib/Executors/ScriptExecutor.swift#L6 Everything else is great!

f-meloni commented 5 years ago

Also can you please add the new step to the README? :) After with those two things i will merge this and release a new version straight away 👍

dalu93 commented 5 years ago

Thank @f-meloni, I just added a commit addressing your points

f-meloni commented 5 years ago

Thanks to you @dalu93, will wait the CI and then i will merge it. 👍

f-meloni commented 5 years ago

Released on 0.5.0 👍