search

shibatch / sleef

SIMD Library for Evaluating Elementary Functions, vectorized libm and DFT
https://sleef.org
Boost Software License 1.0
635 stars 129 forks source link

Do not define our own mpfr_sinpi/mpfr_cospi for mpfr 4.2.0 and later #471

Closed musicinmybrain closed 9 months ago

musicinmybrain commented 11 months ago

These two functions were added to the MPFR API.

Fixes #458.

This is offered as alternative to https://github.com/shibatch/sleef/pull/462, in case you would like to maintain backwards compatibility with MPFR versions earlier than 4.2.0. I don’t view either PR as better than the other; it’s merely a matter of choice.

blapie commented 10 months ago

@musicinmybrain Hello, Would you mind rebasing your branch on top of master so we can test this through the new CI? Cheers

musicinmybrain commented 10 months ago

@musicinmybrain Hello, Would you mind rebasing your branch on top of master so we can test this through the new CI? Cheers

Done!

blapie commented 10 months ago

@musicinmybrain Brilliant, thanks! Should be able to merge next week, thanks a lot for the contribution!

blapie commented 9 months ago

@musicinmybrain Hi! Could you please rebase again so it picks up the last CI checks? Will merge after. Thanks!

musicinmybrain commented 9 months ago

Rebased.