search

shibatch / sleef

SIMD Library for Evaluating Elementary Functions, vectorized libm and DFT
https://sleef.org
Boost Software License 1.0
628 stars 126 forks source link

Mark Sleef_rempitabq* constants as static #536

Closed luhenry closed 3 months ago

luhenry commented 4 months ago

Without marking it static, it fails to compile when including multiple sleefinline_*.h into the same compilation unit.

Co-Authored-By: Hamlin Li hamlin@rivosinc.com

joeramsay commented 4 months ago

Would you mind adding static to Sleef_rempitabsp as well?

including multiple sleefinline_*.h into the same compilation unit.

This should already be addressed by the include guard around the rempi tables. Are you sure the issue isn't from linking multiple objects that all included the header and use the table?

luhenry commented 4 months ago

@joeramsay fixed.

joeramsay commented 4 months ago

Thanks, looks good to me (I don't have commit rights here though)

luhenry commented 4 months ago

@blapie hi, what would be the path forward for this? Thanks!

nSircombe commented 4 months ago

Hi @luhenry, it should be possible to move this on soon (see https://github.com/shibatch/sleef/pull/537#issuecomment-2063895882)