shibatch / sleef

SIMD Library for Evaluating Elementary Functions, vectorized libm and DFT

https://sleef.org

Boost Software License 1.0

661 stars 131 forks source link

This patch fixes two problems #592

Closed shibatch closed 1 week ago

shibatch commented 1 week ago

Checklist

[x] I have read the contributing guidelines.
[x] I have considered portability of my change across platforms and architectures.
[x] I have self-reviewed my code.
[x] I have commented my code where necessary.
[x] I have updated the documentation accordingly.
[x] I have added tests that prove my fix is effective or that my feature works.

What is the purpose of this pull request?

Fix bugs
- On aarch32, cbrt(4) was returned instead of M_PI/2 when INFINITY is given to atanf.
- Due to a bug in gcc-13, sign of tanf(+-0) was wrong with PUREC_SCALAR.

What changes did you make?

Changed a constant in sleefsimdsp.c to fix the value returned by xatanf when INFINITY is given on aarch32.
Add a workaround that fixes the wrong sign of tanf with PUREC_SCALAR when compiled with gcc-13.
Add testing for the first problem. The second problem is detected by the existing tester.

Does this PR relate to any existing issue?

These changes are required to implement https://github.com/shibatch/sleef/issues/574, because these problems are also detected by the new tester.