shibayan / keyvault-acmebot

Automated ACME SSL/TLS certificates issuer for Azure Key Vault (App Service / Container Apps / App Gateway / Front Door / CDN / others)
Apache License 2.0
891 stars 233 forks source link

Authorizations from ACME servers with status=valid results in an error #690

Closed treidel closed 5 months ago

treidel commented 5 months ago

Describe the bug An unexpected error is seen when attempting to request a certificate when the ACME server returns an Authorization object where the status is already valid when the Order is created. This can be the case when a requested domain has been pre-verified in the ACME account. In these cases g. the status of the Authorization will be valid without the ACME client needing to deploy a DNS secret to prove domain control.

To Reproduce Steps to reproduce the behavior:

Environment (please complete the following information):

Additional context

Example JSON of a Authorization object response that triggers the error.
{"identifier":{"type":"dns","value":"test1.testcertificates.com"},"status":"valid","challenges":[],"wildcard":false}

shibayan commented 5 months ago

Thanks for the feedback. We were not aware of that case, we would like to review the PR and if it is not a problem, we would like to go through to the release.