search

shibayan / keyvault-acmebot

Automated ACME SSL/TLS certificates issuer for Azure Key Vault (App Service / Container Apps / App Gateway / Front Door / CDN / others)
Apache License 2.0
891 stars 233 forks source link

Publish versions for win/linux x32/x64, not just win-x32 #730

Closed JohnLBevan closed 1 month ago

JohnLBevan commented 1 month ago

Currently the publish pipeline is set to build images only for win-x32. If using a different app service plan this image cannot be used. There's a new app service plan, Flex Consumption, which will be useful for providing network integration (e.g. for those not wanting to expose key vaults publicly), but that is only available on a Linux image. By providing builds for other OS types / archictures, this will make it simpler for others to onboard this tool.

Note: I've left backwards compatible code in place for the win-x32 image, to ensure that the latest.zip file still gets created with the same name / path & azuredeploy.bicep file to ensure that existing implementations won't be negatively impacted by the changes.

Please say if any issues / concerns / changes required.

Thanks in advance; and thank-you for building such a great tool in the first place.

shibayan commented 1 month ago

Unfortunately, Flex Consumption only supports .NET Isolated, so the current version of Acmebot cannot handle it simply by changing the build settings. Support for migrating to .NET Isolated and handling Flex Consumption is planned for Acmebot v5.

We are also considering support for Linux in v4, but for the reasons mentioned above, we currently only plan to support Azure Functions on Container Apps. This will be provided as a pre-built Docker image.

JohnLBevan commented 1 month ago

Ah no worries; thank-you.