search

shibayan / terraform-azurerm-keyvault-acmebot

Terraform Module for Key Vault Acmebot
Apache License 2.0
31 stars 35 forks source link

Replaced deprecated resources #30

Closed nathanbacon closed 2 years ago

nathanbacon commented 2 years ago

I was deploying the terraform module and I noticed warnings about deprecated resources like this:

The 'azurerm_app_service_plan' resource has been superseded by the 'azurerm_service_plan' resource. Whilst this resource will continue to be available in the 2.x │ and 3.x releases it is feature-frozen for compatibility purposes, will no longer receive any updates and will be removed in a future major release of the Azure │ Provider.

I replaced azurerm_app_service_plan with azurerm_service_plan using compatible settings. The OS wasn't specified previously but since windows was the default, I used that. I also replaced azurerm_function_app with azurerm_windows_function_app.

I deployed with my fork and the added my domain and the app worked fine.

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/service_plan https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/azurerm_windows_function_app

shibayan commented 2 years ago

Thanks PR, the breaking change in Terraform Provider v3 has a wide impact, so the support for Terraform Provider v3 will be done at the same time as the support for Acmebot v4.