search

shibayan / terraform-azurerm-keyvault-acmebot

Terraform Module for Key Vault Acmebot
Apache License 2.0
31 stars 35 forks source link

Add Private endpoint capability #40

Closed bioinformaticsbejo closed 1 year ago

bioinformaticsbejo commented 1 year ago

Adds Private Endpoint integration

sorry for the 100+ commits.

shibayan commented 1 year ago

This PR cannot be merged.

The reason is that there are very few scenarios in which Private Endpoints need to be used, and the majority of users do not need them, yet we need to force a disruptive change.

Please modify the forked module and use it.

bioinformaticsbejo commented 1 year ago

Hi @shibayan

Thanks for the quick response,

I can't see a scenario where I would leave all my DNS open to the whole internet.

The way I coded, with the subnet in a list, if you don't set it up there will be no change in the deployment and it will work as before.

Regards

shibayan commented 1 year ago

The decision to use Private Endpoint should be left to the user. In your scenario, a Private Endpoint may be essential, but for many users it is not.

bioinformaticsbejo commented 1 year ago

@shibayan agreed. that's why it is still optional in the code. anyways. thanks for the awesome tool. works like a charm regards