Adding tags variable

[mjneuharth]

Adding tags variable as additional_tags per request https://github.com/shibayan/terraform-azurerm-keyvault-acmebot/issues/46

Additionally:

Re-organization and alphabetization

• Moved all locals into locals
• Updates to variables.tf
  • Alphabetized
  • Revised for description first as that can get lost if type is first and is elaborate
  • Added placeholder descriptions on the DNS-related variables where it was missing

Added:

• terraform-docs config (docs/header.md include the old README contents)
  • added terraform-docs github action as fail-on-diff for PRs
• revised the example and included it in terraform-docs-generated README
• ignoring .terraform.lock.hcl
• New keyvault_acmebot_version which defaults to "latest"
  • This is consumed by function_app.app_settings to determine the function app version to download
• New additional_tags variable for user-supplied tags
• Locals merges additional_tags with internal_tags and those are applied to resources with all_tags
  • new internal_tags local contains:
  • KeyvaultACMEBotVersion
  • TerraformModuleRepository
  • TerraformModuleVersion
• Updated mail_address to email_address
  • Add variable validation to ensure a valid-looking email address is provided

My use case is regularly rerunning terraform without unexpectedly replacing the acmebot version and greater traceability on resources deployed within our environments. Tags are free, right?

I think it would be nice to provide folks some control over the version of keyvault-acmebot they pull when using the terraform module. And I think you can continue to support "latest" with a package that gets replaced as latest when new versions are deployed in the storage account for this while also providing explicit package versions.

Happy to revise here too.

[Janbong]

Hi, I'm also interested in this feature. Can this be merged? Thanks in advance!

[shibayan]

Pull Requests with such major changes cannot be merged without discussion. It needs to be created in smaller units.