shibayan / terraform-azurerm-keyvault-acmebot

Terraform Module for Key Vault Acmebot
Apache License 2.0
31 stars 35 forks source link

Add allowed_applications field #65

Closed jalvarezit closed 7 months ago

jalvarezit commented 7 months ago
jalvarezit commented 7 months ago

@shibayan I believe that feature is interesting e.g. for qa environments where you do not want to track errors and avoiding that extra cost matters. Additionally it comes by default enabled so you need to specifically set it to false to not include it.

shibayan commented 7 months ago

Tracking errors is for my benefit as well. I cannot sustain development if my support costs increase to save a few cents per month.

Of course you are free to customize your environment, but I would prefer that this be an official module.

jalvarezit commented 7 months ago

@shibayan Do you use Application Insights to send any sort of telemetry in order to solve bugs or is it because you do not want to waste time solving errors without logs enabled making it harder and more time consuming to find a solutio?.

Either case I believe is just better to let the user decide and if they do not have it enabled do not give any bug support at all.

shibayan commented 7 months ago

It doesn't seem reasonable that every time an Issue is created I have to check to see if I have Application Insights enabled each time. The module will not implement the option to enable or disable Application Insights in the future.

jalvarezit commented 7 months ago

@shibayan We can just ignore that feature and merge the other two?