search

shibbir / generator-angular2-typescript

Yeoman generator to scaffold out a front-end project with angular, typescript, webpack and much more..
https://www.npmjs.com/package/generator-angular2-typescript
MIT License
35 stars 7 forks source link

Update _package.json #13

Closed smartm0use closed 8 years ago

smartm0use commented 8 years ago

Migrate to Angular 2.0 RC6

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1eb3f3828300008ac853844df6adf1cc6d6f7cef on smartm0use:patch-1 into d00c09e45eec8230c530849e8d3980afa0c625af on shibbir:master.

smartm0use commented 8 years ago

Maybe there are more fixes to add:

npm WARN @angular/http@2.0.0-rc.6 requires a peer of rxjs@5.0.0-beta.11 but none was installed.
npm WARN @angular/core@2.0.0-rc.6 requires a peer of rxjs@5.0.0-beta.11 but none was installed.
npm WARN @angular/router@3.0.0-rc.2 requires a peer of rxjs@5.0.0-beta.11 but none was installed.
shibbir commented 8 years ago

Hi @smartm0use,

Only updating the package.json would break the app. Its better to also update the codes with the package updates. I'm going to accept your pull request though. But please consider this for next time.

Cheers :+1:

smartm0use commented 8 years ago

I see, thank you. Keep up the good work.