1.4.1: pep517 build fails

kloczek commented 2 years ago

Source code from git tag

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 363, in <module>
    main()
  File "/usr/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 345, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "/usr/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 130, in get_requires_for_build_wheel
    return hook(config_settings)
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 177, in get_requires_for_build_wheel
    return self._get_build_requires(
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 159, in _get_build_requires
    self.run_setup()
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 281, in run_setup
    super(_BuildMetaLegacyBackend,
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 174, in run_setup
    exec(compile(code, __file__, 'exec'), locals())
  File "setup.py", line 4, in <module>
    from imagesize import __version__
ImportError: cannot import name '__version__' from 'imagesize' (unknown location)

aodag commented 2 years ago

You may not have image/init.py. This file can be found in tar ball downloaded from PyPI, but not commited on github repository.

$ cat .venv/lib/python3.10/site-packages/imagesize/__init__.py 
__all__ = ["get", "getDPI", "__version__"]

__version__ = "1.4.1"

from .imagesize import get, getDPI

kloczek commented 2 years ago

So why this file is not generated by pep517 buuild?

shibukawa commented 2 years ago

Sorry, I pushed missing file and retagged 1.4.1.

kloczek commented 2 years ago

Thank you very much 👍 Just retested and all looks good 😄

shibukawa / imagesize_py

1.4.1: pep517 build fails #54