Plugin still runs when toggled in community plugins

shichongrui / obsidian-reveal-active-file

Obsidian plugin to reveal the active file automatically when you open a file

86 stars 10 forks source link

Plugin still runs when toggled in community plugins #8

Open Aaron-Bopp opened 2 years ago

Aaron-Bopp commented 2 years ago

It seems if you have this on and then toggle it off, it will continue to run until you close and reopen obsidian

rzfzr commented 2 years ago

I notice this kind of thing in other plugins/settings, it is an obsidian issue on applying changes. On the commands list you can select Reload app or even add it to an hotkey.

pjeby commented 6 months ago

It's not an issue with Obsidian, it's an issue with the plugin not calling this.registerEvent() on the return value of its this.workspace.on() calls. So when the plugin is disabled, it's not deactivating the handling for those events. If there are other plugins that don't properly deactivate when you disable them, they're probably broken in a similar way.