shidhincr / LookAround

AngularJS Learning Playground ( with Twitter bootstrap, Google maps API, TDD using Karma runner )

MIT License

174 stars 149 forks source link

Use bower for package management #17

Closed anuja-joshi closed 8 years ago

anuja-joshi commented 8 years ago

I recommend using bower for client side asset management as it makes dependency management easier. Also, it's the convention.

shidhincr commented 8 years ago

Agree.. It would be better if we change the Angular and Angular router load from bower packages

sahilbhatia commented 8 years ago

@shidhincr @anuja-joshi

I am working on it. Will rebase and push the changes once you accept the pull request for issue #12

Waiting for you to accept issue #12 as that includes changes for ngRoute.

shidhincr commented 8 years ago

@anuja-joshi @sahilbhatia I'll accept the PR now. The only problem is that, the changes for removing the sensor got removed when I merged the changes. So you might need to add that change again in your next PR.

shidhincr commented 8 years ago

16 is merged

sahilbhatia commented 8 years ago

Thanks @shidhincr :smile:

anuja-joshi commented 8 years ago

@sahilbhatia will you be adding bower_components folder to git repo?

sahilbhatia commented 8 years ago

Yes @anuja-joshi , I am planning to push it to git. I know it will increase the repo size but I see the following advantages of adding it to git:

Demo app is running on heroku (without the dependencies committed, the target server (e.g. Heroku) must run bower install to generate the dependencies)
Deployment process will no longer be dependent on availability of Bower repository

@anuja-joshi @shidhincr What are your thougts on this?

shidhincr commented 8 years ago

@sahilbhatia I wouldn't rather do that. Because:

It's always better to do the bower install ( on build time ), so that we get the dependencies updated, and will know about any breaking changes.
For any new user who uses the app, it's better to do bower install on their machine rather than serving the whole bunch of files.
If we start adding more dependencies, this will be a pain to see whole bunch of these files in the commit history.

anuja-joshi commented 8 years ago

@sahilbhatia I agree with approach suggested by @shidhincr , You can specify bower as dependency in package.json and add bower install in postinstall section. You can refer this.

sahilbhatia commented 8 years ago

Fair enough, will not push bower_compnents to git. Instead, I will add bower as dependency to package.json as suggested by @anuja-joshi above.