search

shidhincr / LookAround

AngularJS Learning Playground ( with Twitter bootstrap, Google maps API, TDD using Karma runner )
MIT License
174 stars 149 forks source link

Xliffv1 #2

Closed Xliff closed 10 years ago

Xliff commented 10 years ago

Added numbered markers and allows marker centering in both list and map views.

Xliff commented 10 years ago

I noticed your project in GitHub and would like you to consider these usability changes I've made. All changes are subject to discussion.

Looking forward to hearing from you.

shidhincr commented 10 years ago

Hey @Xliff ,

Thank you for the pull request. Nice job !!

Overall the PR is great and I would like to merge it soon. Can you please work on the changes I commented? It's simple, just need to have the consistency and indentation.

Let me know once you do that, I'll merge the PR.

Xliff commented 10 years ago

I've updated the branch with the changes you've suggested. See if this handles all of your issues.

shidhincr commented 10 years ago

Thanks @Xliff .. I am merging the PR