search

shieldproject / shield-boshrelease

BOSH Release for shield
MIT License
11 stars 17 forks source link

Don't use -%> since it's not supported by bosh create-env #107

Closed rkoster closed 6 years ago

rkoster commented 6 years ago

will look into the failure and add some template tests.

jhunt commented 6 years ago

My guess is that the go stdlib can't deal with the newline at the end of the keyfile, which is why we were using -%> in the first place.

Does the BOSH CLI team know that hyphen-trimming isn't supported by create-env? If not, perhaps we should file an issue there instead. If so, we should try to get some focus on the issue so that it gets resolved upstream.

rkoster commented 6 years ago

have created: https://github.com/cloudfoundry/bosh-cli/issues/381

rkoster commented 6 years ago

@jhunt is there use case for not specifying an agent.key?

rkoster commented 6 years ago

@jhunt any preference on where to run the release unit tests?

jhunt commented 6 years ago

Let's just wait until upstream the bosh-cli fix is incorporated.

lnguyen commented 6 years ago

:+1: I have this issue now

jhunt commented 6 years ago

Fixed in c7b330c