search

shieldproject / shield-boshrelease

BOSH Release for shield
MIT License
11 stars 17 forks source link

Expose Timeout,Workers to shield-daemon config #90

Closed karampok closed 7 years ago

karampok commented 7 years ago

Here is a small pull request to resolve #88

I proposed that the variables are always written to the config file of shield-daemon so that the (default) values are easily visible to the operator. The alternative would have been the vars not to be there, in which case the operator should look the shield codebase to see the default values.

Not sure if the description Max number of concurrent tasks in running state is accurate.

Thx

karampok commented 7 years ago

I am not sure why concourse is failing. Are there some pipelines that I can run against concourse-lite to verify the pull requests?

drnic commented 7 years ago

@karampok I'll investigate the CI failure. The PR support is something I'm working on. Can you confirm that your PR is based on master/HEAD?

drnic commented 7 years ago

@karampok Yep, if you can do the CI system a favour and rebase your branch against upstream master branch, then CI should work. Sorry for the inconvenience.

screen shot 2017-08-19 at 7 13 12 am

karampok commented 7 years ago

yes, no problem. Now it looks better!

jhunt commented 7 years ago

Don't forget to add release notes when you make changes...

drnic commented 7 years ago

Ahh sorry I forgot to look for them in the PR before merging. I'll add them manually.

From: James Hunt notifications@github.com Sent: Sunday, August 20, 2017 9:39:26 PM To: starkandwayne/shield-boshrelease Cc: Dr Nic Williams; State change Subject: Re: [starkandwayne/shield-boshrelease] Expose Timeout,Workers to shield-daemon config (#90)

Don't forget to add release notes when you make changes...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/starkandwayne/shield-boshrelease/pull/90#issuecomment-323579662, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAAAbHXXtBUkRNayAVU3BcwXPNyr7WEQks5saBrtgaJpZM4O7Til.