shieldproject / shield

A standalone system that can perform backup and restore functions for a wide variety of pluggable data systems
MIT License
371 stars 69 forks source link

[BUG] metashield plugin should trust system pool if ca not specified #687

Closed thomasmitchell closed 4 years ago

thomasmitchell commented 4 years ago

Describe the bug If CA certificate is not specified to the metashield plugin, then the SHIELD endpoint can never actually be trusted.

To Reproduce Steps to reproduce the behavior:

  1. Make a metashield backup against a shield server with a system pool trusted certificate
  2. Don't skip ssl validation
  3. Don't specify a ca certificate
  4. watch the backup fail

Expected behavior I expected the plugin to use the system certificate pool if no ca was given

Screenshots If applicable, add screenshots to help explain your problem.

SHIELD versions (please complete the following information):

Browser version(s) (please complete if reporting a web UI bug):

Additional context Add any other context about the problem here.

sriniketh923 commented 4 years ago

Should be fixed now