shieldproject / shield

A standalone system that can perform backup and restore functions for a wide variety of pluggable data systems
MIT License
371 stars 69 forks source link

shield create-store does not ask AWS information when creating store in s3[BUG] #688

Open xiujiao opened 4 years ago

xiujiao commented 4 years ago

Describe the bug When I run shield create-store, I went through the following steps

shield create-store
Store Name: test
Description: to store backup for stuff
SHIELD Agent (IP:port): x.x.x.x:5444
Backup Plugin: s3
Threshold: 5G

It did not ask me information on AWS key ID and secret and bucket name, caused the store to fail after being created. I was able to run shield update-store to add those missing entries and the store did work after that.

To Reproduce shield create-store with s3 plugin

Expected behavior It should ask information on S3 authentication and bucket since it is required to make the store work

SHIELD versions (please complete the following information):

jhunt commented 4 years ago

This is a "works as designed" part of the SHIELD CLI; Perhaps the better approach is to remove the semi-interactive form and just rely on command-line parameters for everything.