search

shieldproject / shield

A standalone system that can perform backup and restore functions for a wide variety of pluggable data systems
MIT License
363 stars 69 forks source link

fix ordering of vault status checks even more #695

Closed thomasmitchell closed 4 years ago

thomasmitchell commented 4 years ago

This would behave poorly if shieldd had been restarted but not Vault - the Vault would not be uninitialized or sealed, so the health check wouldn't return an error, and so the function would return Ready. But we actually wouldn't have a token yet, so backups would fail.

I had screwed up the ordering when I tried to fix the previous ordering, which would check for token validity before checking for vault seal/uninit status.

To validate that this works, it needs to be tested that the unseals and backs up as expected

  1. on a clean install
  2. after a restart of both vault and shield
  3. after a restart of just shield
  4. after a restart of just vault
sriniketh923 commented 4 years ago

Finished testing this and good to me merged!

jhunt commented 4 years ago

Is the desire to merge this about short-term support for 8.x? Vault integration goes away in v9...

sriniketh923 commented 4 years ago

Yes, it's for 8.x.

stale[bot] commented 4 years ago

This issue has been automatically marked as abandoned because it has not seen any activity or updates in 30 days. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.