shiffman / shiffman.net

Archive of Daniel Shiffman website
https://shiffman-archive.netlify.app/
133 stars 66 forks source link

Accessibility updates #95

Closed phucduong86 closed 5 years ago

phucduong86 commented 5 years ago

Details:

phucduong86 commented 5 years ago

Hi Dan,

Here's some screenshots of the main elements. I tried not to change the color scheme too much and just darken the existing colors. The biggest change is the yellow color - it's looking more like a green now the other option is keeping the green but make the text darker. I feel that the later would break the consistency of the color scheme on the right panel. image image image image image

shiffman commented 5 years ago

Thank you @phucduong86, this is so great! I think the green color probably needs re-thinking but accessibility for me is a higher priority than looking nice. So perhaps we merge this but open a new issue inviting proposals for different color schemes with the contrast requirements?

phucduong86 commented 5 years ago

Thank you @phucduong86, this is so great! I think the green color probably needs re-thinking but accessibility for me is a higher priority than looking nice. So perhaps we merge this but open a new issue inviting proposals for different color schemes with the contrast requirements?

That sounds great Dan! Thank you for the review.