shift72 / kibble

Apache License 2.0
2 stars 1 forks source link

added validation for language api response #113

Closed PeculiarGoat closed 2 years ago

PeculiarGoat commented 2 years ago

ADO card.

What it says on the tin.

PeculiarGoat commented 2 years ago

@stajs I felt it would be better to collect all of the errors before returning so we can see all of the issues at once. Otherwise it will be like fix a thing, fail a build, fix another thing, fail another build, and so on.

stajs commented 2 years ago

I don't think that's worth the effort. Fixing things in order seems a reasonable expectation and means the code is slightly simplified and the tests can expect a single error for each condition.

PeculiarGoat commented 2 years ago

@stajs kk I'll change it.

PeculiarGoat commented 2 years ago

@stajs sorted!

josejibin commented 2 years ago

LGTM