search

shiftcommerce / flex-ruby-gem

💎 The Ruby library used to integrate with the Shift Platform API
MIT License
2 stars 0 forks source link

Update version of json_api_client #157

Closed JoshuaTatterton closed 5 years ago

JoshuaTatterton commented 6 years ago

At the time of writing this ticket we're currently using version 1.1.1 of the json_api_client gem and the latest version available is 1.5.3.

In the shift oms gem we're using the latest version 1.5.3, so this is clashing when trying to install both in the Flex Platform.

A branch already exists in the flex ruby gem upgrading the version update_json_api_client_gem. This currently includes upgrading the json_api_client and updating the patches as needed (removing one as it has been merged and deployed)

The updated branch needs further testing on both the F/E (test/ruby_gem_with_update) and the B/E (flex_ruby_gem_update_jsonapi_client) at the branches provided. Once both tests suites pass then the gem can get released on both and the oms can be integrated properly into the admin panel.

mzishtiaq commented 6 years ago

Taking the ticket dealing with the bloat as the priority has been increased for it.

mufudzimasaire commented 6 years ago

FYI: the Flex Deployment Client will also need updating - 

Bundler could not find compatible versions for gem "json_api_client":
  In snapshot (Gemfile.lock):
    json_api_client (= 1.1.1)

  In Gemfile:
    flex_deployment_client was resolved to 0.1.1, which depends on
      json_api_client (~> 1.0)

    shift_commerce_oms was resolved to 0.1.0, which depends on
      shift-api-core (~> 0.2) was resolved to 0.2.0, which depends on
        json_api_client (~> 1.5)
cbarratt commented 6 years ago

^ I've created a branch/PR for flex_deployment_client, not entirely sure how's best to test this as I currently haven't yet handled a deployment.

adamdullenty commented 5 years ago

Closed by #158