search

shiftdsm / Galavanting-Gnome

0 stars 1 forks source link

Add jest and lint #36

Closed tegandbiscuits closed 5 years ago

tegandbiscuits commented 5 years ago

Added jest and ran linting which hadn't been done for a bit.

tegandbiscuits commented 5 years ago

@codebycliff these tests work, but there's something funky going on where it's not quitting. It suggests running with detectOpenHandles, but that doesn't actually seem to do anything for me.

You can run tests fine with --watch, but wouldn't be able to in a CI service without --forceExit. I'm ok with this getting merged soon, so we have something. If we want to use circle-ci, then I wouldn't be opposed to adding --forceExit, but I'd prefer to get it sorted out first.