search

shiftkey / desktop

Fork of GitHub Desktop to support various Linux distributions
MIT License
6.57k stars 493 forks source link

ChromeOS - Cannot Authenticate #1014

Open Malix-off opened 4 months ago

Malix-off commented 4 months ago

The problem

Cannot authenticate on ChromeOS (flatpak github desktop version)

Release version

Version 3.3.6-linux3 (x64)

Operating system

Steps to reproduce the behavior

  1. Download and Install ChromeOS (can be portable)
  2. Enable "Linux development environment"
  3. Install flatpak on Crostini
  4. Install GitHub Desktop (Flatpak)
  5. Try to authenticate

Log files

2024-02-24T18:49:46.557Z - info: [ui] [AppStore] loading 0 repositories from store
2024-02-24T18:49:47.156Z - info: [ui] launching: 3.3.6-linux3 (Linux 6.6.13-00891-g1af58030b5c8)
2024-02-24T18:49:47.181Z - info: [ui] execPath: '/app/github-desktop/github-desktop'
2024-02-24T18:49:47.567Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:49:48.113Z - info: [ui] Opt in reported.
2024-02-24T18:49:48.298Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:49:50.862Z - info: [ui] [Welcome] advancing to step: SignInToDotComWithBrowser
2024-02-24T18:49:50.883Z - info: [ui] [SignInStore] initializing OAuth flow
2024-02-24T18:49:50.941Z - info: [main] opening in browser: https://github.com/login/oauth/authorize?client_id=3a723b10ac5575cc5bb9&scope=repo%20user%20workflow&state=c4d888aa-a9b1-4e14-8c69-502a4233df43
2024-02-24T18:49:50.963Z - info: [ui] [Welcome] current sign in state not found. ignoring...
2024-02-24T18:49:51.687Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2024-02-24T18:50:09.843Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2024-02-24T18:50:10.959Z - info: [main] Received possible protocol arguments: 3
2024-02-24T18:50:10.966Z - info: [main] Processing protocol url
2024-02-24T18:50:10.980Z - info: [ui] [Dispatcher] requesting authenticated user
2024-02-24T18:50:10.991Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2024-02-24T18:50:11.545Z - info: [main] Received possible protocol arguments: 2
2024-02-24T18:50:12.608Z - info: [ui] [SignInStore] account resolved
2024-02-24T18:50:12.699Z - info: [ui] [AppStore] adding account Malix-off (Malix) to store
2024-02-24T18:50:12.699Z - info: [ui] [Welcome] advancing to step: ConfigureGit
2024-02-24T18:50:13.149Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:13.185Z - error: [ui] Error adding account 'Malix-off'
Error: user interaction failed
2024-02-24T18:50:13.363Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:17.662Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:18.532Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:22.504Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:22.743Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:25.455Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:50:30.340Z - info: [ui] [Welcome] no sign in step found. ignoring...
2024-02-24T18:51:05.843Z - info: [ui] [SignInStore] initializing OAuth flow
2024-02-24T18:51:05.902Z - info: [main] opening in browser: https://github.com/login/oauth/authorize?client_id=3a723b10ac5575cc5bb9&scope=repo%20user%20workflow&state=72c95603-f28b-4807-94c9-645deb3331b0
2024-02-24T18:51:07.982Z - info: [main] Received possible protocol arguments: 3
2024-02-24T18:51:07.982Z - info: [main] Processing protocol url
2024-02-24T18:51:07.989Z - info: [ui] [Dispatcher] requesting authenticated user
2024-02-24T18:51:08.995Z - info: [ui] [SignInStore] account resolved
2024-02-24T18:51:09.000Z - info: [ui] [AppStore] adding account Malix-off (Malix) to store
2024-02-24T18:51:09.069Z - error: [ui] Error adding account 'Malix-off'
Error: user interaction failed
2024-02-24T18:52:50.905Z - info: [ui] [AppStore] loading 0 repositories from store
2024-02-24T18:52:51.065Z - info: [ui] launching: 3.3.6-linux3 (Linux 6.6.13-00891-g1af58030b5c8)
2024-02-24T18:52:51.081Z - info: [ui] execPath: '/app/github-desktop/github-desktop'
2024-02-24T18:52:51.767Z - info: [ui] Stats reported.
2024-02-24T18:53:30.088Z - info: [ui] [AppStore] loading 0 repositories from store
2024-02-24T18:53:30.289Z - info: [ui] launching: 3.3.6-linux3 (Linux 6.6.13-00891-g1af58030b5c8)
2024-02-24T18:53:30.313Z - info: [ui] execPath: '/app/github-desktop/github-desktop'
2024-02-24T18:55:46.561Z - info: [ui] [SignInStore] initializing OAuth flow
2024-02-24T18:55:46.634Z - info: [main] opening in browser: https://github.com/login/oauth/authorize?client_id=3a723b10ac5575cc5bb9&scope=repo%20user%20workflow&state=45fa0878-e01c-423e-8643-707a345d8e9b
2024-02-24T18:55:48.977Z - info: [main] Received possible protocol arguments: 3
2024-02-24T18:55:48.991Z - info: [main] Processing protocol url
2024-02-24T18:55:48.991Z - info: [ui] [Dispatcher] requesting authenticated user
2024-02-24T18:55:50.230Z - info: [ui] [SignInStore] account resolved
2024-02-24T18:55:50.237Z - info: [ui] [AppStore] adding account Malix-off (Malix) to store
2024-02-24T18:55:50.333Z - error: [ui] Error adding account 'Malix-off'
Error: user interaction failed

Screenshots

image

shiftkey commented 4 months ago

Error: user interaction failed

This is a generic error from the keychain, as we need somewhere to store the token received from the browser sign-in flow. Unless you have a libsecret-compatible package installed like gnome-keyring this will not work.

Malix-off commented 4 months ago

Ohkay, understandable. I'm not using a libsecret-compatible keyring lib but will test with the gnome one later.

It would be very nice to feat a customized message for that error!

wiiznokes commented 1 week ago

Could the keyring stuff be an option? I personally don't want to use it

Malix-off commented 1 week ago

How would you register your secret, then ?