`x-github-desktop-dev-auth://` did not register for AppImage

codemedic commented 3 years ago

Operating System/Distribution

Which distribution of Linux are you using?

KDE Neon which is based on Ubuntu 16.04.7 LTS

Installer

Which version of the app? GitHubDesktop-linux-2.9.0-linux4.AppImage

Which installer type? AppImage

What happened?

Provide as much detail as possible. Error messages or output are extremely useful.

When installing, I got these errors on terminal.

~$ apps/GitHubDesktop-linux-2.9.0-linux4.AppImage
xdg-mime: application argument missing
Try 'xdg-mime --help' for more information.
xdg-mime: application argument missing
Try 'xdg-mime --help' for more information.
(node:13351) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information

Then when I finish the OAuth, the link x-github-desktop-dev-auth://oauth?code=... does not open in the app. It is behaving as if the protocol (x-github-desktop-dev-auth://) did not get registered.

shiftkey commented 3 years ago

:wave: thanks for the report. There are a couple of related issues in this area - #542 #416 - and aside from setting the right config value like we did back in #496 I'm not sure how to proceed.

The most interesting clue was https://github.com/shiftkey/desktop/issues/542#issuecomment-875017330 and the logs for a user where the URL was received by the app but it wasn't in a format the app understood:

2021-06-30T19:01:03.001Z - warn: [ui] Unknown URL action: unknown - payload: {"name":"unknown","url":"--no-sandbox"}

From my perspective, it looks like whatever was launching the app wasn't including the URL - the --no-sandbox is just a setting that Electron itself understands. Not sure if that's relevant to your situation, but it does seem like the app is launching at least.

Seeing xdg-mime complain like that is new to me. Perhaps there's some Electron updates that mean the app has issues with Ubuntu 16.04 and derivative distributions...

Mrlinkwii commented 3 years ago

if your using firefox ( which i persum you are ) have a look at this comment https://github.com/shiftkey/desktop/issues/542#issuecomment-895269081 you have to manually select the appimage , if that dosent happen , revoke the auth , and start the processes , it should work then

codemedic commented 3 years ago

Thanks, I will take a look at those and post back. My browser is Google Chrome 92

shiftkey / desktop